/adei/trunk

To get this branch, use:
bzr branch http://darksoft.org/webbzr/adei/trunk

« back to all changes in this revision

Viewing changes to services/download.php

  • Committer: Suren A. Chilingaryan
  • Date: 2012-04-18 13:59:12 UTC
  • Revision ID: csa@dside.dyndns.org-20120418135912-6xff7ljcv5t6vnn7
Use htmlentities while reporting errors in download manager to avoid corrupted XML

Show diffs side-by-side

added added

removed removed

Lines of Context:
services/download.php
40
40
    default:
41
41
      throw new ADEIException(translate("Error with download service: Target ( $target ) not valid"));
42
42
    break;
43
 
  }   
44
 
   
 
43
  }
45
44
} catch(ADEIException $ex) {  
46
 
   
47
 
   throw new ADEIException(translate("Error with download service. Target: $target \n Error: $ex"));   
48
 
  }
 
45
    throw new ADEIException(translate("Error with download service. Target: $target \n Error: $ex"));   
 
46
}
49
47
 
50
48
  function CreateDownloadXml($props, $mode) {
51
49
    $XMLoutput = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n";
55
53
        foreach($props as $download) {   
56
54
        $XMLoutput .= "<download";
57
55
          foreach($download as $key => $value) {
58
 
            $XMLoutput .= " $key=\"$value\"";
 
56
            $XMLoutput .= " $key=\"" . htmlentities($value) . "\"";
59
57
          }     
60
58
        $XMLoutput .= "></download>\n";
61
59
        }       
63
61
      break;
64
62
      case 'dlmanager_details':
65
63
        $XMLoutput .= "<groups>";
66
 
        if(!empty($props['props']['error'])) $XMLoutput .= "<error>{$props['props']['error']}</error>";
 
64
        if(!empty($props['props']['error'])) $XMLoutput .= "<error>" . htmlentities($props['props']['error']) . "</error>";
67
65
        $XMLoutput .= "<window><from>{$props['props']['window']['from']}</from><to>{$props['props']['window']['to']}</to></window>";    //
68
66
        $XMLoutput .= "<data><format>{$props['props']['format']}</format><size>{$props['props']['size']}</size></data>";
69
67