From acc27900faf0501a22e9c20da27bd7f103392636 Mon Sep 17 00:00:00 2001 From: Scott Dodson Date: Tue, 7 Mar 2017 19:55:00 -0500 Subject: Fix pylint/pyflakes errors on master --- roles/openshift_logging/filter_plugins/openshift_logging.py | 3 ++- roles/openshift_logging/tasks/install_logging.yaml | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/roles/openshift_logging/filter_plugins/openshift_logging.py b/roles/openshift_logging/filter_plugins/openshift_logging.py index f0007dfc7..9beffaef7 100644 --- a/roles/openshift_logging/filter_plugins/openshift_logging.py +++ b/roles/openshift_logging/filter_plugins/openshift_logging.py @@ -28,10 +28,11 @@ def entry_from_named_pair(register_pairs, key): def map_from_pairs(source, delim="="): ''' Returns a dict given the source and delim delimited ''' if source == '': - return dict() + return dict() return dict(source.split(delim) for item in source.split(",")) + # pylint: disable=too-few-public-methods class FilterModule(object): ''' OpenShift Logging Filters ''' diff --git a/roles/openshift_logging/tasks/install_logging.yaml b/roles/openshift_logging/tasks/install_logging.yaml index 1beff3bfc..83b68fa77 100644 --- a/roles/openshift_logging/tasks/install_logging.yaml +++ b/roles/openshift_logging/tasks/install_logging.yaml @@ -77,8 +77,8 @@ loop_control: loop_var: sa_account when: - - openshift_logging_image_pull_secret is defined - - openshift_logging_image_pull_secret != '' + - openshift_logging_image_pull_secret is defined + - openshift_logging_image_pull_secret != '' failed_when: link_pull_secret.rc != 0 - name: Scaling up cluster -- cgit v1.2.1