From 47d06eda6a989477d2f618c1872cf7635744173a Mon Sep 17 00:00:00 2001 From: Michael Gugino Date: Mon, 12 Feb 2018 14:17:13 -0500 Subject: Fix gcp variable warnings This commit ensures that user get better information regarding variables that need to be defined in inventory when using gcp. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1541589 --- roles/openshift_cloud_provider/tasks/gce.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/roles/openshift_cloud_provider/tasks/gce.yml b/roles/openshift_cloud_provider/tasks/gce.yml index 9e1c31b1d..dff5fa09c 100644 --- a/roles/openshift_cloud_provider/tasks/gce.yml +++ b/roles/openshift_cloud_provider/tasks/gce.yml @@ -1,11 +1,13 @@ --- - name: check variables are passed fail: - msg: "Ensure correct variables are defined for gcp. {{ item }}" - when: item == '' + msg: "Ensure correct variables are defined for gcp. {{ item.name }}" + when: item.value == '' with_items: - - "{{ openshift_gcp_project }}" - - "{{ openshift_gcp_prefix }}" + - name: openshift_gcp_project + value: "{{ openshift_gcp_project }}" + - name: openshift_gcp_prefix + value: "{{ openshift_gcp_prefix }}" # Work around ini_file create option in 2.2 which defaults to no - name: Create cloud config file -- cgit v1.2.1