diff options
| author | Leonardo Rodrigues de Mello <l@lmello.eu.org> | 2017-02-23 23:53:59 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-02-23 23:53:59 +0000 |
| commit | eb40863bf898c8bef19e978e163c00b055de8f19 (patch) | |
| tree | 5afd22694f6dab7fdc454e48d92c77f6909e1d9f /roles/openshift_logging/files | |
| parent | aec9cd888fdc83b8c3f82f469bd07c66aa5183b1 (diff) | |
| download | openshift-eb40863bf898c8bef19e978e163c00b055de8f19.tar.gz openshift-eb40863bf898c8bef19e978e163c00b055de8f19.tar.bz2 openshift-eb40863bf898c8bef19e978e163c00b055de8f19.tar.xz openshift-eb40863bf898c8bef19e978e163c00b055de8f19.zip | |
change shell to bash in generate_jks.sh
The generate_jks.sh script uses non-posix standard shell features, this breaks the openshift_logging
installation if the controller node is running debian or ubuntu.
This problem was not spot before because probably all the developers use fedora or redhat/centos and
in redhat based distributions the /bin/sh is a symlink to bash.
Debian and ubuntu adopted dash a long time ago and in debian/ubuntu controller nodes /bin/sh is a symlink
to dash, that does not support the extended feature set required by this script.
This commit changes the shell to bash to ensure it is run with a shell interpreter that supports the extended feature.
https://www.shellcheck.net/
https://wiki.ubuntu.com/DashAsBinSh
Diffstat (limited to 'roles/openshift_logging/files')
| -rw-r--r-- | roles/openshift_logging/files/generate-jks.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/roles/openshift_logging/files/generate-jks.sh b/roles/openshift_logging/files/generate-jks.sh index 9fe557f83..b5ba7f9d1 100644 --- a/roles/openshift_logging/files/generate-jks.sh +++ b/roles/openshift_logging/files/generate-jks.sh @@ -1,4 +1,4 @@ -#! /bin/sh +#! /bin/bash set -ex function usage() { |