summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Wiest <twiest@users.noreply.github.com>2015-06-24 11:00:54 -0400
committerThomas Wiest <twiest@users.noreply.github.com>2015-06-24 11:00:54 -0400
commitb02c7b49602c446cddbcd5d6f763321bb8414131 (patch)
tree352c601eced4d72bbc4a72064158da8a30f0eea4
parent430e8ae6039bc9788a3a907fe76b0b0b2c85a90d (diff)
parentfeed0b5595bb65b553459b6c6c256de51a4c4276 (diff)
downloadopenshift-b02c7b49602c446cddbcd5d6f763321bb8414131.tar.gz
openshift-b02c7b49602c446cddbcd5d6f763321bb8414131.tar.bz2
openshift-b02c7b49602c446cddbcd5d6f763321bb8414131.tar.xz
openshift-b02c7b49602c446cddbcd5d6f763321bb8414131.zip
Merge pull request #298 from twiest/aa2
added python new method params should use a default value to best practices guide.
-rw-r--r--docs/best_practices_guide.adoc26
1 files changed, 26 insertions, 0 deletions
diff --git a/docs/best_practices_guide.adoc b/docs/best_practices_guide.adoc
index 912617461..1e96655e1 100644
--- a/docs/best_practices_guide.adoc
+++ b/docs/best_practices_guide.adoc
@@ -27,6 +27,32 @@ The tooling is flexible enough that exceptions can be made so that the tool the
== Python
+=== Method Signatures
+
+'''
+[cols="2v,v"]
+|===
+| **Rule**
+| When adding a new paramemter to an existing method, a default value SHOULD be used
+|===
+The purpose of this rule is to make it so that method signatures are backwards compatible.
+
+If this rule isn't followed, it will be necessary for the person who changed the method to search out all callers and make sure that they're able to use the new method signature.
+
+Example:
+.Before:
+[source,python]
+----
+def add_person(first_name, last_name):
+----
+
+.After:
+[source,python]
+----
+def add_person(first_name, last_name, age=None):
+----
+
+
=== PyLint
http://www.pylint.org/[PyLint] is used in an attempt to keep the python code as clean and as managable as possible. The build bot runs each pull request through PyLint and any warnings or errors cause the build bot to fail the pull request.