summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorScott Dodson <sdodson@redhat.com>2017-03-07 19:55:00 -0500
committerScott Dodson <sdodson@redhat.com>2017-03-07 20:01:37 -0500
commitacc27900faf0501a22e9c20da27bd7f103392636 (patch)
tree0d57617b3985031501c2165ec4784c7f7ff822a7
parentf77dc7824917b973b8f92028e4efaea57cc3036c (diff)
downloadopenshift-acc27900faf0501a22e9c20da27bd7f103392636.tar.gz
openshift-acc27900faf0501a22e9c20da27bd7f103392636.tar.bz2
openshift-acc27900faf0501a22e9c20da27bd7f103392636.tar.xz
openshift-acc27900faf0501a22e9c20da27bd7f103392636.zip
Fix pylint/pyflakes errors on master
-rw-r--r--roles/openshift_logging/filter_plugins/openshift_logging.py3
-rw-r--r--roles/openshift_logging/tasks/install_logging.yaml4
2 files changed, 4 insertions, 3 deletions
diff --git a/roles/openshift_logging/filter_plugins/openshift_logging.py b/roles/openshift_logging/filter_plugins/openshift_logging.py
index f0007dfc7..9beffaef7 100644
--- a/roles/openshift_logging/filter_plugins/openshift_logging.py
+++ b/roles/openshift_logging/filter_plugins/openshift_logging.py
@@ -28,10 +28,11 @@ def entry_from_named_pair(register_pairs, key):
def map_from_pairs(source, delim="="):
''' Returns a dict given the source and delim delimited '''
if source == '':
- return dict()
+ return dict()
return dict(source.split(delim) for item in source.split(","))
+
# pylint: disable=too-few-public-methods
class FilterModule(object):
''' OpenShift Logging Filters '''
diff --git a/roles/openshift_logging/tasks/install_logging.yaml b/roles/openshift_logging/tasks/install_logging.yaml
index 1beff3bfc..83b68fa77 100644
--- a/roles/openshift_logging/tasks/install_logging.yaml
+++ b/roles/openshift_logging/tasks/install_logging.yaml
@@ -77,8 +77,8 @@
loop_control:
loop_var: sa_account
when:
- - openshift_logging_image_pull_secret is defined
- - openshift_logging_image_pull_secret != ''
+ - openshift_logging_image_pull_secret is defined
+ - openshift_logging_image_pull_secret != ''
failed_when: link_pull_secret.rc != 0
- name: Scaling up cluster