summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamuel Munilla <smunilla@redhat.com>2016-10-03 14:29:06 -0400
committerSamuel Munilla <smunilla@redhat.com>2016-10-03 14:29:06 -0400
commit39a9d188209c50698c6694a655f79e9200914b94 (patch)
treec9cf211dbf8adda2e9d50deeb892981aee0153a2
parent2128e5cfd89de206004e33d58ecfca594c87c3d7 (diff)
downloadopenshift-39a9d188209c50698c6694a655f79e9200914b94.tar.gz
openshift-39a9d188209c50698c6694a655f79e9200914b94.tar.bz2
openshift-39a9d188209c50698c6694a655f79e9200914b94.tar.xz
openshift-39a9d188209c50698c6694a655f79e9200914b94.zip
a-o-i: Force option should allow reinstall
If uninstalled hosts were in detected in an environment, the installer could get into a hung state that a user could not easily recover from. This lets --force do what is more expected.
-rw-r--r--utils/src/ooinstall/cli_installer.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/utils/src/ooinstall/cli_installer.py b/utils/src/ooinstall/cli_installer.py
index 43b1b3244..347ae7ec9 100644
--- a/utils/src/ooinstall/cli_installer.py
+++ b/utils/src/ooinstall/cli_installer.py
@@ -751,7 +751,9 @@ def get_hosts_to_run_on(oo_cfg, callback_facts, unattended, force, verbose):
hosts_to_run_on.remove(host)
# Handle the cases where we know about uninstalled systems
- if len(uninstalled_hosts) > 0:
+ # TODO: This logic is getting hard to understand.
+ # we should revise all this to be cleaner.
+ if not force and len(uninstalled_hosts) > 0:
for uninstalled_host in uninstalled_hosts:
click.echo("{} is currently uninstalled".format(uninstalled_host))
# Fall through